base/json: Get rid of static initializer in JSONReader.

base/json: Get rid of static initializer in JSONReader.

Convert kInvalidToken to a static function in Token class called CreateInvalidToken().

This should get rid of the problem with the static initialization.

BUG=94925
TEST=base_unittests --gtest_filter=JSON*

R=tony@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99200

[tfarina, 2011-09-01 01:21:06]

http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc
File base/json/json_reader.cc (right):

http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc#newcode88
base/json/json_reader.cc:88: : kInvalidToken(new Token(Token::INVALID_TOKEN, 0,
0)),
I'm not convinced this is the best way to do this. Is there a better way to
write this?

[tony, 2011-09-01 01:48:11]

http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc
File base/json/json_reader.cc (right):

http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc#newcode88
base/json/json_reader.cc:88: : kInvalidToken(new Token(Token::INVALID_TOKEN, 0,
0)),
On 2011/09/01 01:21:07, tfarina wrote:
> I'm not convinced this is the best way to do this. Is there a better way to
> write this?

I think we should just get rid of kInvalidToken and return
Token(Token::INVALID_TOKEN, 0, 0) directly.  If you don't like the
repetitiveness, you could add a static function to Token like
Token::CreateInvalidToken() that returns an invalid token.

[tfarina, 2011-09-01 02:20:18]

On 2011/09/01 01:48:11, tony wrote:
> http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc
> File base/json/json_reader.cc (right):
> 
>
http://codereview.chromium.org/7756022/diff/1/base/json/json_reader.cc#newcode88
> base/json/json_reader.cc:88: : kInvalidToken(new Token(Token::INVALID_TOKEN,
0,
> 0)),
> On 2011/09/01 01:21:07, tfarina wrote:
> > I'm not convinced this is the best way to do this. Is there a better way to
> > write this?
> 
> I think we should just get rid of kInvalidToken and return
> Token(Token::INVALID_TOKEN, 0, 0) directly.  If you don't like the
> repetitiveness, you could add a static function to Token like
> Token::CreateInvalidToken() that returns an invalid token.

Sure, added Token::CreateInvalidToken(). Feels better to me ;)

Please, take another look.

[tony, 2011-09-01 16:17:43]

LGTM, thanks!