Issue 7754014: Fix bug in collector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7754014: Fix bug in collector. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 3 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix bug in collector. Small cleanups in preparser. TEST=cctest/test-utils/SequenceCollectorRegression Committed: http://code.google.com/p/v8/source/detail?r=9197

Patch Set 1 #

Total comments: 4

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -33 lines)			Patch
M	src/preparser.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/preparser.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/utils.h	View	3 chunks	+29 lines, -25 lines	2 comments	Download
M	test/cctest/test-utils.cc	View	1 chunk	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM with nit http://codereview.chromium.org/7754014/diff/1/src/utils.h File src/utils.h (right): http://codereview.chromium.org/7754014/diff/1/src/utils.h#newcode617 src/utils.h:617: Vector<T> new_chunk = Vector<T>::New(new_capacity); We don't ...

9 years, 3 months ago (2011-09-08 13:42:37 UTC) #2

Lasse Reichstein

9 years, 3 months ago (2011-09-08 13:43:42 UTC) #3

http://codereview.chromium.org/7754014/diff/1/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/7754014/diff/1/src/utils.h#newcode617
src/utils.h:617: Vector<T> new_chunk = Vector<T>::New(new_capacity);
Gone.

http://codereview.chromium.org/7754014/diff/1/test/cctest/test-utils.cc
File test/cctest/test-utils.cc (right):

http://codereview.chromium.org/7754014/diff/1/test/cctest/test-utils.cc#newco...
test/cctest/test-utils.cc:205: i::Vector<const
char>("12345678901234567890123456789012", 32));
Absolutely.

Expand Messages | Collapse Messages