Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 7754010: Re-use phi reachability information to avoid a fixed-point computation. (Closed)

Created:
9 years, 3 months ago by Sven Panne
Modified:
9 years, 3 months ago
Reviewers:
fschneider, danno
CC:
v8-dev
Visibility:
Public.

Description

Re-use phi reachability information to avoid a fixed-point computation. When we propagate the information that a value is not convertible to integer, there is no need for a separate fixed-point computation, we can do things the "Millikin way" (tm), folding as much computation as possible into a single pass: ;-) We already have the phi node reachability information, so we can easily propagate this while doing the representation histogram computation. Committed: http://code.google.com/p/v8/source/detail?r=9212

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M src/hydrogen.cc View 1 2 chunks +11 lines, -25 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 3 months ago (2011-09-08 12:25:00 UTC) #1
danno
LGTM
9 years, 3 months ago (2011-09-09 08:40:01 UTC) #2
fschneider
9 years, 3 months ago (2011-09-09 13:02:07 UTC) #3
LGTM as well.

http://codereview.chromium.org/7754010/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7754010/diff/1/src/hydrogen.cc#newcode1712
src/hydrogen.cc:1712: 
Remove extra newlines.

Powered by Google App Engine
This is Rietveld 408576698