Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4043)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_model.cc

Issue 7754008: Omnibox enters keyword search mode incorrectly (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fixed nits Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_popup_model.cc
diff --git a/chrome/browser/autocomplete/autocomplete_popup_model.cc b/chrome/browser/autocomplete/autocomplete_popup_model.cc
index 041e1f06f49b3cddc488d90894daab8dbe30a2c5..0cc2412683891faea7644180c4e456e43a21520b 100644
--- a/chrome/browser/autocomplete/autocomplete_popup_model.cc
+++ b/chrome/browser/autocomplete/autocomplete_popup_model.cc
@@ -132,27 +132,12 @@ bool AutocompletePopupModel::GetKeywordForMatch(const AutocompleteMatch& match,
// Assume we have no keyword until we find otherwise.
keyword->clear();
- if (match.template_url) {
- TemplateURLService* url_service =
- TemplateURLServiceFactory::GetForProfile(edit_model_->profile());
- if (!url_service)
- return false;
-
- // Only show the keyword for the default provider if the user typed in
- // the keyword and it isn't SEARCH_WHAT_YOU_TYPED.
- const TemplateURL* default_url = url_service->GetDefaultSearchProvider();
- if (default_url && (default_url->id() == match.template_url->id())) {
- if (StartsWith(autocomplete_controller()->input().text(),
- default_url->keyword(), false) &&
- (match.type != AutocompleteMatch::SEARCH_WHAT_YOU_TYPED)) {
- keyword->assign(match.template_url->keyword());
- return false;
- }
- } else if (TemplateURL::SupportsReplacement(match.template_url)) {
- // The current match is a keyword, return that as the selected keyword.
- keyword->assign(match.template_url->keyword());
- return false;
- }
+ if (match.template_url &&
+ TemplateURL::SupportsReplacement(match.template_url) &&
+ match.transition == PageTransition::KEYWORD) {
+ // The current match is a keyword, return that as the selected keyword.
+ keyword->assign(match.template_url->keyword());
+ return false;
}
// See if the current match's fill_into_edit corresponds to a keyword.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698