Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: ppapi/generators/idl_generator.py

Issue 7753042: Update generator for Chrome generation as the default case (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/generators/idl_c_header.py ('k') | ppapi/generators/idl_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/generators/idl_generator.py
===================================================================
--- ppapi/generators/idl_generator.py (revision 98485)
+++ ppapi/generators/idl_generator.py (working copy)
@@ -11,8 +11,8 @@
GeneratorList = []
-Option('release', 'Which release to generate.', default='M14')
-Option('range', 'Which release ranges in the form of MIN,MAX.', default='')
+Option('release', 'Which release to generate.', default='')
+Option('range', 'Which ranges in the form of MIN,MAX.', default='M13,M14')
#
@@ -67,7 +67,7 @@
releasestr = GetOption('release')
# Check for a range option which over-rides a release option
- if rangestr:
+ if not releasestr and rangestr:
range_list = rangestr.split(',')
if len(range_list) != 2:
self.Error('Failed to generate for %s, incorrect range: "%s"' %
@@ -77,12 +77,17 @@
vmax = range_list[1]
vmin = ast.releases.index(vmin)
vmax = ast.releases.index(vmax) + 1
- ret = self.GenerateRange(ast, ast.releases[vmin:vmax], options)
+ range = ast.releases[vmin:vmax]
+ InfoOut.Log('Generate range %s of %s.' % (range, self.name))
+ ret = self.GenerateRange(ast, range, options)
if ret < 0:
self.Error('Failed to generate range %s : %s.' %(vmin, vmax))
+ else:
+ InfoOut.Log('%s wrote %d files.' % (self.name, ret))
# Otherwise this should be a single release generation
else:
if releasestr:
+ InfoOut.Log('Generate release %s of %s.' % (releasestr, self.name))
ret = self.GenerateRelease(ast, releasestr, options)
if ret < 0:
self.Error('Failed to generate release %s.' % releasestr)
« no previous file with comments | « ppapi/generators/idl_c_header.py ('k') | ppapi/generators/idl_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698