Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 7753038: Move TooltipWindowGtk from views/widget to ui/base/gtk. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dhollowa
Visibility:
Public.

Description

Move TooltipWindowGtk from views/widget to ui/base/gtk. TooltipWidgetGtk is a gtk based helper class that replaces a widget's default tooltip with a RGBA friendly version. It's not closely coupled with views and ui/base/gtk seems to be a better home for it. This move gets rid of RenderWidgetHostViewGtk's dependency on views. BUG=none. TEST=Expect no change. ChromeOS's tooltip should still have rounded corners. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98475

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments in #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -171 lines) Patch
M content/browser/renderer_host/render_widget_host_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/base/gtk/tooltip_window_gtk.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/base/gtk/tooltip_window_gtk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/tooltip_manager_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
D views/widget/tooltip_window_gtk.h View 1 chunk +0 lines, -58 lines 0 comments Download
D views/widget/tooltip_window_gtk.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-26 16:49:14 UTC) #1
jam
lgtm, thanks http://codereview.chromium.org/7753038/diff/1/ui/base/gtk/tooltip_window_gtk.cc File ui/base/gtk/tooltip_window_gtk.cc (right): http://codereview.chromium.org/7753038/diff/1/ui/base/gtk/tooltip_window_gtk.cc#newcode95 ui/base/gtk/tooltip_window_gtk.cc:95: } // namespace views nit: ui http://codereview.chromium.org/7753038/diff/1/ui/base/gtk/tooltip_window_gtk.h ...
9 years, 4 months ago (2011-08-26 16:52:59 UTC) #2
xiyuan
Thanks for the quick review. Nits fixed and will submit after trybots greenness. http://codereview.chromium.org/7753038/diff/1/ui/base/gtk/tooltip_window_gtk.cc File ...
9 years, 4 months ago (2011-08-26 16:56:40 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-26 20:09:59 UTC) #4
Can't process patch for file ui/base/gtk/tooltip_window_gtk.cc.
A +

Powered by Google App Engine
This is Rietveld 408576698