[Sync] Add tests for migration triggered by notifications

chrome/browser/sync/notifier/p2p_notifier.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/notifier/p2p_notifier.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/sync/notifier/sync_notifier_observer.h"
 #include "chrome/browser/sync/protocol/service_constants.h"
 #include "chrome/browser/sync/syncable/model_type_payload_map.h"
 
 namespace sync_notifier {
 
+const char* kSyncP2PNotificationChannel = "http://www.google.com/chrome/sync";
+
 namespace {
 
-const char kSyncNotificationChannel[] = "http://www.google.com/chrome/sync";
-
 const char kNotifySelf[] = "notifySelf";
 const char kNotifyOthers[] = "notifyOthers";
 const char kNotifyAll[] = "notifyAll";
 
 const char kSenderIdKey[] = "senderId";
 const char kNotificationTypeKey[] = "notificationType";
 const char kChangedTypesKey[] = "changedTypes";
 
 }  // namespace
 
@@ skipping 155 matching lines @@
   // If already logged in, the new credentials will take effect on the
   // next reconnection.
   talk_mediator_->SetAuthToken(email, token, SYNC_SERVICE_NAME);
   if (!logged_in_) {
     if (!talk_mediator_->Login()) {
       LOG(DFATAL) << "Could not login for " << email;
       return;
     }
 
     notifier::Subscription subscription;
-    subscription.channel = kSyncNotificationChannel;
+    subscription.channel = kSyncP2PNotificationChannel;
     // There may be some subtle issues around case sensitivity of the
     // from field, but it doesn't matter too much since this is only
     // used in p2p mode (which is only used in testing).
     subscription.from = email;
     talk_mediator_->AddSubscription(subscription);
 
     logged_in_ = true;
   }
 }
 
@@ skipping 37 matching lines @@
   DCHECK(parent_message_loop_proxy_->BelongsToCurrentThread());
   VLOG(1) << "Received notification " << notification.ToString();
   if (!logged_in_) {
     VLOG(1) << "Not logged in yet -- not emitting notification";
     return;
   }
   if (!notifications_enabled_) {
     VLOG(1) << "Notifications not enabled -- not emitting notification";
     return;
   }
-  if (notification.channel != kSyncNotificationChannel) {
+  if (notification.channel != kSyncP2PNotificationChannel) {
     LOG(WARNING) << "Notification from unexpected source "
                  << notification.channel;
   }
   P2PNotificationData notification_data;
   if (!notification_data.ResetFromString(notification.data)) {
     LOG(WARNING) << "Could not parse notification data from "
                  << notification.data;
     notification_data =
         P2PNotificationData(unique_id_, NOTIFY_ALL, enabled_types_);
   }
@@ skipping 18 matching lines @@
 
 void P2PNotifier::SendNotificationDataForTest(
     const P2PNotificationData& notification_data) {
   SendNotificationData(notification_data);
 }
 
 void P2PNotifier::SendNotificationData(
     const P2PNotificationData& notification_data) {
   DCHECK(parent_message_loop_proxy_->BelongsToCurrentThread());
   notifier::Notification notification;
-  notification.channel = kSyncNotificationChannel;
+  notification.channel = kSyncP2PNotificationChannel;
   notification.data = notification_data.ToString();
   VLOG(1) << "Sending XMPP notification: " << notification.ToString();
   talk_mediator_->SendNotification(notification);
 }
 
 }  // namespace sync_notifier