Notify selection controller on tab changes.

Notify selection controller on tab changes.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98495

[sky, 2011-08-25 22:54:17]

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:153: if
(touch_selection_controller_.get()) {
What happens if the page scrolls before you get here, or the page is relayed
out? Do both of these trigger calls to SelectionChanged?

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.h (right):

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.h:270: gfx::Point
touch_selection_start_;
These aren't necessarily touch related. So name them
selection_start_/selection_end_

[varunjain, 2011-08-25 23:49:22]

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:153: if
(touch_selection_controller_.get()) {
On 2011/08/25 22:54:17, sky wrote:
> What happens if the page scrolls before you get here, or the page is relayed
> out? Do both of these trigger calls to SelectionChanged?

Yes.. selection_start and end will be updated appropriately in both cases
through SelectionChanged

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.h (right):

http://codereview.chromium.org/7753015/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.h:270: gfx::Point
touch_selection_start_;
On 2011/08/25 22:54:17, sky wrote:
> These aren't necessarily touch related. So name them
> selection_start_/selection_end_

Done.

[sky, 2011-08-26 15:42:54]

LGTM

[commit-bot: I haz the power, 2011-08-26 21:52:51]

Change committed as 98495