Issue 7753010: [ChromeOS] Make "createAccount" and "guestSignin" keyboard friendly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7753010: [ChromeOS] Make "createAccount" and "guestSignin" keyboard friendly. (Closed)

Created:
9 years, 4 months ago by xiyuan

Modified:
9 years, 4 months ago

Reviewers:
achuithb, commit-bot: I haz the power

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[ChromeOS] Make "createAccount" and "guestSignin" keyboard friendly. BUG=chromium-os:19650 TEST=Verify fix for chromium-os:19650 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98334

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/resources/chromeos/login/screen_gaia_signin.html	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/login/screen_signin.css	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

LGTM. http://codereview.chromium.org/7753010/diff/1/chrome/browser/resources/chromeos/login/screen_signin.css File chrome/browser/resources/chromeos/login/screen_signin.css (right): http://codereview.chromium.org/7753010/diff/1/chrome/browser/resources/chromeos/login/screen_signin.css#newcode26 chrome/browser/resources/chromeos/login/screen_signin.css:26: display: block; just curious: is this necessary for ...

9 years, 4 months ago (2011-08-25 21:29:48 UTC) #2

commit-bot: I haz the power

9 years, 4 months ago (2011-08-25 22:19:31 UTC) #3

Try job failure for 7753010-1 (retry) on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages