Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/sync/glue/typed_url_model_associator.cc

Issue 7753008: [Sync] Verify writing to history backend in typed urls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/typed_url_model_associator.cc
diff --git a/chrome/browser/sync/glue/typed_url_model_associator.cc b/chrome/browser/sync/glue/typed_url_model_associator.cc
index bcb1a434f67bfb8d6f132602e59d350e216fa968..03965d6355fdc45f970f37280d5e6d8c1d1a9925 100644
--- a/chrome/browser/sync/glue/typed_url_model_associator.cc
+++ b/chrome/browser/sync/glue/typed_url_model_associator.cc
@@ -265,8 +265,14 @@ bool TypedUrlModelAssociator::AssociateModels(SyncError* error) {
// this is the only thread that writes to the database. We also don't have
// to worry about the sync model getting out of sync, because changes are
// propagated to the ChangeProcessor on this thread.
- return WriteToHistoryBackend(&titles, &new_urls, &updated_urls,
- &new_visits, NULL);
+ if (!WriteToHistoryBackend(&titles, &new_urls, &updated_urls,
+ &new_visits, NULL)) {
+ error->Reset(FROM_HERE,
+ "Failed to write to history backend",
+ model_type());
+ return false;
+ }
+ return true;
}
bool TypedUrlModelAssociator::DeleteAllNodes(
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698