Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Side by Side Diff: src/spaces.h

Issue 7753001: Fixed bool <-> Executability confusion and improved typing a bit. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/spaces.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 // only after PagedSpace::PrepareForMarkCompact was called. 193 // only after PagedSpace::PrepareForMarkCompact was called.
194 inline bool WasInUseBeforeMC(); 194 inline bool WasInUseBeforeMC();
195 195
196 inline void SetWasInUseBeforeMC(bool was_in_use); 196 inline void SetWasInUseBeforeMC(bool was_in_use);
197 197
198 // True if this page is a large object page. 198 // True if this page is a large object page.
199 inline bool IsLargeObjectPage(); 199 inline bool IsLargeObjectPage();
200 200
201 inline void SetIsLargeObjectPage(bool is_large_object_page); 201 inline void SetIsLargeObjectPage(bool is_large_object_page);
202 202
203 inline bool IsPageExecutable(); 203 inline Executability PageExecutability();
204 204
205 inline void SetIsPageExecutable(bool is_page_executable); 205 inline void SetPageExecutability(Executability executable);
206 206
207 // Returns the offset of a given address to this page. 207 // Returns the offset of a given address to this page.
208 INLINE(int Offset(Address a)) { 208 INLINE(int Offset(Address a)) {
209 int offset = static_cast<int>(a - address()); 209 int offset = static_cast<int>(a - address());
210 ASSERT_PAGE_OFFSET(offset); 210 ASSERT_PAGE_OFFSET(offset);
211 return offset; 211 return offset;
212 } 212 }
213 213
214 // Returns the address for a given offset to the this page. 214 // Returns the address for a given offset to the this page.
215 Address OffsetToAddress(int offset) { 215 Address OffsetToAddress(int offset) {
(...skipping 2089 matching lines...) Expand 10 before | Expand all | Expand 10 after
2305 } 2305 }
2306 // Must be small, since an iteration is used for lookup. 2306 // Must be small, since an iteration is used for lookup.
2307 static const int kMaxComments = 64; 2307 static const int kMaxComments = 64;
2308 }; 2308 };
2309 #endif 2309 #endif
2310 2310
2311 2311
2312 } } // namespace v8::internal 2312 } } // namespace v8::internal
2313 2313
2314 #endif // V8_SPACES_H_ 2314 #endif // V8_SPACES_H_
OLDNEW
« no previous file with comments | « no previous file | src/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698