Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 7751001: More multi-version support (part 2) (Closed)

Created:
9 years, 4 months ago by noelallen1
Modified:
9 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

More multi-version support (part 2) Add member to Node to return a set of unique releases for that node. Updates DefineStruct to iterate across all unique releases for the struct, generating first the most recent release as we do today and other releases without comments, and the version number appended to the structure name. NOTE: This is work in progress. This CL adds support for Interfaces that change which should be enough for M15. While this same CL creates multiple structures when the structures change, references to structures will not have mangled names which would cause errors. BUG= http://code.google.com/p/chromium/issues/detail?id=89969 TEST= python generator.py --cgen --test --diff --range=M13,M14 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98298

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -31 lines) Patch
M ppapi/generators/idl_c_header.py View 1 2 1 chunk +8 lines, -9 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 2 1 chunk +23 lines, -7 lines 0 comments Download
M ppapi/generators/idl_namespace.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/generators/idl_node.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M ppapi/generators/test_cgen_range/versions.h View 1 2 2 chunks +32 lines, -8 lines 0 comments Download
M ppapi/generators/test_cgen_range/versions.idl View 1 2 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
noelallen1
9 years, 4 months ago (2011-08-25 05:47:09 UTC) #1
noelallen1
9 years, 4 months ago (2011-08-25 18:42:32 UTC) #2
brettw
LGTM http://codereview.chromium.org/7751001/diff/4001/ppapi/generators/idl_node.py File ppapi/generators/idl_node.py (right): http://codereview.chromium.org/7751001/diff/4001/ppapi/generators/idl_node.py#newcode277 ppapi/generators/idl_node.py:277: # Given a list of release, return a ...
9 years, 4 months ago (2011-08-25 19:32:29 UTC) #3
noelallen1
9 years, 4 months ago (2011-08-25 19:38:28 UTC) #4
http://codereview.chromium.org/7751001/diff/4001/ppapi/generators/idl_node.py
File ppapi/generators/idl_node.py (right):

http://codereview.chromium.org/7751001/diff/4001/ppapi/generators/idl_node.py...
ppapi/generators/idl_node.py:277: # Given a list of release, return a subset of
releases that change
On 2011/08/25 19:32:29, brettw wrote:
> Style nit: need period.

Done.

Powered by Google App Engine
This is Rietveld 408576698