Issue 7749030: Revert 98319 - Make a channel and time limited persistent PreRead experiment...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7749030: Revert 98319 - Make a channel and time limited persistent PreRead experiment... (Closed)

Created:
9 years, 4 months ago by chrisha

Modified:
9 years, 4 months ago

Reviewers:
chrisha, jbates

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 98319 - Make a channel and time limited persistent PreRead experiment Our previous PreRead experiment involved flipping a coin on every launch, but we wish to persist the coin-toss between launches. Additionally, this version of the field trial includes an expiry date and limits it to the canary and dev channels. We are unable to use the FieldTrial mechanism due to PreRead occuring prior to chrome.dll being loaded. As such, we use the registry for persisting the coin-toss and environment variables for communicating between chrome.exe and chrome.dll. Review URL: http://codereview.chromium.org/7712014 TBR=chrisha@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98388

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -173 lines)			Patch
M	chrome/app/client_util.cc	View	7 chunks	+4 lines, -112 lines	0 comments	Download
M	chrome/browser/browser_main.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	4 chunks	+6 lines, -44 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chrisha

The official waterfall was actually failing (despite the try-bots all passing), so I reverted this ...

9 years, 4 months ago (2011-08-26 03:02:27 UTC) #2

jbates

9 years, 4 months ago (2011-08-26 03:15:16 UTC) #3

On 2011/08/26 03:02:27, chrisha wrote:
> The official waterfall was actually failing (despite the try-bots all
passing),
> so I reverted this CL. Can you review this for me?

LGTM

Expand Messages | Collapse Messages