Issue 7749028: Compositor leaks all resources if tab is closed and it's not the last in the process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7749028: Compositor leaks all resources if tab is closed and it's not the last in the process (Closed)

Created:
9 years, 4 months ago by jamesr

Modified:
9 years, 2 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/

Visibility:
Public.

Description

Compositor leaks all resources if tab is closed and it's not the last in the process Fixes leaks when turning the compositor off. Ref counting is evil. BUG=94329 TEST=open up poster circle, look at GPU process memory use, duplicate tab a bunch of times, close all tabs but one. GPU process memory go back to where it was at step 1

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -8 lines)			Patch
M	Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	View	1 chunk	+12 lines, -3 lines	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	View	3 chunks	+23 lines, -4 lines	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/TextureManager.cpp	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

Hi Enne, Can you sanity check this against m14 for me? Thanks.

9 years, 4 months ago (2011-08-26 01:21:03 UTC) #1

enne (OOO)

9 years, 4 months ago (2011-08-26 22:17:03 UTC) #2

LGTM.

http://codereview.chromium.org/7749028/diff/1/Source/WebCore/platform/graphic...
File Source/WebCore/platform/graphics/chromium/TextureManager.cpp (left):

http://codereview.chromium.org/7749028/diff/1/Source/WebCore/platform/graphic...
Source/WebCore/platform/graphics/chromium/TextureManager.cpp:88:
ASSERT(!m_textures.get(token).isProtected);
Nit: This doesn't seem necessary.  Maybe you didn't mean to upload this change?
I plan to remove it before landing.

Expand Messages | Collapse Messages