Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: chrome/test/automation/automation_proxy_uitest.cc

Issue 7749018: Disable some automation proxy tests. They always fail, and hang for up to 90 seconds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/automation_proxy_uitest.cc
===================================================================
--- chrome/test/automation/automation_proxy_uitest.cc (revision 97912)
+++ chrome/test/automation/automation_proxy_uitest.cc (working copy)
@@ -1080,8 +1080,8 @@
loop.RunFor(TestTimeouts::action_max_timeout_ms());
}
-// Flaky, http://crbug.com/42545.
-TEST_F(ExternalTabUITest, FLAKY_HostNetworkStack) {
+// Disabled, http://crbug.com/42545.
+TEST_F(ExternalTabUITest, DISABLED_HostNetworkStack) {
scoped_refptr<TabProxy> tab;
TimedMessageLoopRunner loop(MessageLoop::current());
ASSERT_THAT(mock_, testing::NotNull());
@@ -1151,8 +1151,8 @@
loop.RunFor(TestTimeouts::action_max_timeout_ms());
}
-// Flaky, http://crbug.com/61023.
-TEST_F(ExternalTabUITest, FLAKY_HostNetworkStackAbortRequest) {
+// Disabled, http://crbug.com/61023.
+TEST_F(ExternalTabUITest, DISABLED_HostNetworkStackAbortRequest) {
scoped_refptr<TabProxy> tab;
TimedMessageLoopRunner loop(MessageLoop::current());
ASSERT_THAT(mock_, testing::NotNull());
@@ -1193,8 +1193,8 @@
loop.RunFor(TestTimeouts::action_max_timeout_ms());
}
-// Flaky, http://crbug.com/61023.
-TEST_F(ExternalTabUITest, FLAKY_HostNetworkStackUnresponsiveRenderer) {
+// Disabled, http://crbug.com/61023.
+TEST_F(ExternalTabUITest, DISABLED_HostNetworkStackUnresponsiveRenderer) {
scoped_refptr<TabProxy> tab;
TimedMessageLoopRunner loop(MessageLoop::current());
ASSERT_THAT(mock_, testing::NotNull());
@@ -1272,8 +1272,8 @@
#if defined(OS_WIN)
// http://crbug.com/61023 - Fails on one popular operating system.
-#define MAYBE_WindowDotOpen FLAKY_WindowDotOpen
-#define MAYBE_UserGestureTargetBlank FLAKY_UserGestureTargetBlank
+#define MAYBE_WindowDotOpen DISABLED_WindowDotOpen
+#define MAYBE_UserGestureTargetBlank DISABLED_UserGestureTargetBlank
#else
#define MAYBE_WindowDotOpen WindowDotOpen
#define MAYBE_UserGestureTargetBlank UserGestureTargetBlank
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698