Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 7749014: Destructor needs to be virtual. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Correct patch Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/browser/utility_process_host.h" 9 #include "content/browser/utility_process_host.h"
10 #include "content/common/url_fetcher.h" 10 #include "content/common/url_fetcher.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 // Only one of |icon_data| (based64-encoded icon data) or |icon_url| can be 50 // Only one of |icon_data| (based64-encoded icon data) or |icon_url| can be
51 // specified, but it is legal for both to be empty. 51 // specified, but it is legal for both to be empty.
52 WebstoreInstallHelper(Delegate* delegate, 52 WebstoreInstallHelper(Delegate* delegate,
53 const std::string& manifest, 53 const std::string& manifest,
54 const std::string& icon_data, 54 const std::string& icon_data,
55 const GURL& icon_url, 55 const GURL& icon_url,
56 net::URLRequestContextGetter* context_getter); 56 net::URLRequestContextGetter* context_getter);
57 void Start(); 57 void Start();
58 58
59 private: 59 private:
60 ~WebstoreInstallHelper(); 60 virtual ~WebstoreInstallHelper();
61 61
62 void StartWorkOnIOThread(); 62 void StartWorkOnIOThread();
63 void StartFetchedImageDecode(); 63 void StartFetchedImageDecode();
64 void ReportResultsIfComplete(); 64 void ReportResultsIfComplete();
65 void ReportResultFromUIThread(); 65 void ReportResultFromUIThread();
66 66
67 // Implementing the URLFetcher::Delegate interface. 67 // Implementing the URLFetcher::Delegate interface.
68 virtual void OnURLFetchComplete(const URLFetcher* source) OVERRIDE; 68 virtual void OnURLFetchComplete(const URLFetcher* source) OVERRIDE;
69 69
70 // Implementing pieces of the UtilityProcessHost::Client interface. 70 // Implementing pieces of the UtilityProcessHost::Client interface.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 // A details string for keeping track of any errors. 107 // A details string for keeping track of any errors.
108 std::string error_; 108 std::string error_;
109 109
110 // A code to distinguish between an error with the icon, and an error with the 110 // A code to distinguish between an error with the icon, and an error with the
111 // manifest. 111 // manifest.
112 Delegate::InstallHelperResultCode parse_error_; 112 Delegate::InstallHelperResultCode parse_error_;
113 }; 113 };
114 114
115 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 115 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698