Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/browser/download/download_item.h

Issue 7749013: Made the cancel from CancelDownloadOnRename go through the full cancel path, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed error in tests not bailing on select file. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item.h
diff --git a/content/browser/download/download_item.h b/content/browser/download/download_item.h
index 40fdfb2e0afe52398b32d23c66e25207741e4280..5476aa1fc606944cc9e3c39da4088e28b4615e9b 100644
--- a/content/browser/download/download_item.h
+++ b/content/browser/download/download_item.h
@@ -170,7 +170,7 @@ class DownloadItem {
// to display progress when the DownloadItem should be considered complete.
void MarkAsComplete();
- // Called by the delegate after it delayed completing the download in
+ // Called by the delegate after it delayed completing the download in
// DownloadManagerDelegate::ShouldCompleteDownload.
void CompleteDelayedDownload();
@@ -322,6 +322,14 @@ class DownloadItem {
return state_info_.target_name != full_path_.BaseName();
}
+ // Cancels the off-thread aspects of the download.
+ // TODO(rdsmith): This should be private and only called from
+ // DownloadItem::Cancel/Interrupt; it isn't now because we can't
+ // call those functions from
+ // DownloadManager::FileSelectionCancelled() without doing some
+ // rewrites of the DownloadManager queues.
+ void OffThreadCancel(DownloadFileManager* file_manager);
+
std::string DebugString(bool verbose) const;
#ifdef UNIT_TEST

Powered by Google App Engine
This is Rietveld 408576698