Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 7749013: Made the cancel from CancelDownloadOnRename go through the full cancel path, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed error in tests not bailing on select file. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 936fa216d92d95194880d3d0295447aa3cf08c74..e17d5b6378958326ec578636b5e0dbb4fcd78b8b 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -583,7 +583,7 @@ class DownloadTest : public InProcessBrowserTest {
return new DownloadsObserver(
download_manager, num_downloads,
DownloadItem::COMPLETE, // Really done
- false, // Bail on select file
+ true, // Bail on select file
ahendrickson 2011/08/25 21:33:34 What changed?
Randy Smith (Not in Mondays) 2011/08/25 21:41:51 Sam switched it to false accidentally as part of a
ON_DANGEROUS_DOWNLOAD_FAIL);
}
« no previous file with comments | « no previous file | content/browser/download/download_file_manager.cc » ('j') | content/browser/download/download_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698