Made the cancel from CancelDownloadOnRename go through the full cancel path,

Made the cancel from CancelDownloadOnRename go through the full cancel path, 
and added a few more checks for 85408.

BUG=85408
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98474

[Randy Smith (Not in Mondays), 2011-08-25 20:05:20]

Ben, Andy: Could you guys give this a once over?  Preferably quickly, as I
suspect I upped the crash rate in the last canary with my commit, and I'd like
to drop it back down again.

[benjhayden, 2011-08-25 20:41:40]

LGTM

http://codereview.chromium.org/7749013/diff/1006/content/browser/download/dow...
File content/browser/download/download_manager.cc (right):

http://codereview.chromium.org/7749013/diff/1006/content/browser/download/dow...
content/browser/download/download_manager.cc:788: if (download->db_handle() >
largest_handle)
Why not use largest_db_handle_in_history_ here and kill largest_handle?

[Randy Smith (Not in Mondays), 2011-08-25 21:19:55]

http://codereview.chromium.org/7749013/diff/1006/content/browser/download/dow...
File content/browser/download/download_manager.cc (right):

http://codereview.chromium.org/7749013/diff/1006/content/browser/download/dow...
content/browser/download/download_manager.cc:788: if (download->db_handle() >
largest_handle)
On 2011/08/25 20:41:40, b s h wrote:
> Why not use largest_db_handle_in_history_ here and kill largest_handle?

Because I'm being over-paranoid; I'll fix that.  (More specifically, because I
wanted to change ldhih_ atomically, but it's only read on the UI thread and I'm
on the UI thread, and I don't need to worry about that.)  Done.

[ahendrickson, 2011-08-25 21:33:33]

LGTM.

http://codereview.chromium.org/7749013/diff/1006/chrome/browser/download/down...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/7749013/diff/1006/chrome/browser/download/down...
chrome/browser/download/download_browsertest.cc:586: true,                    //
Bail on select file
What changed?

[Randy Smith (Not in Mondays), 2011-08-25 21:41:51]

http://codereview.chromium.org/7749013/diff/1006/chrome/browser/download/down...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/7749013/diff/1006/chrome/browser/download/down...
chrome/browser/download/download_browsertest.cc:586: true,                    //
Bail on select file
On 2011/08/25 21:33:34, ahendrickson wrote:
> What changed?

Sam switched it to false accidentally as part of a CL some time back.  The only
test that trips over it is DISABLED_DownloadMimeTypeSelect, which I run as part
of my normal test suite.  I may not have had a change landed since his that
stuck; it may also flakily break that test.

[commit-bot: I haz the power, 2011-08-26 20:15:33]

Change committed as 98474