Issue 7749011: Plumbs through changing navigator to bookmark menus. This is needed in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7749011: Plumbs through changing navigator to bookmark menus. This is needed in (Closed)

Created:
9 years, 4 months ago by sky

Modified:
9 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Plumbs through changing navigator to bookmark menus. This is needed in case the navigator changes while a menu is showing (as could happen if a tab closes). BUG=92994 TEST=make sure bookmark menus still work; covered by tests too. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98324

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -3 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM