Issue 7748038: Remove BrowserSignin, as it's not used anywhere.

Issue 7748038: Remove BrowserSignin, as it's not used anywhere. (Closed)

Created:
9 years, 4 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, asargent_no_longer_on_chrome, willchan no longer on Chromium

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove BrowserSignin, as it's not used anywhere. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98690

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -905 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/browser_signin.h	View	1 chunk	+0 lines, -116 lines	0 comments	Download
D	chrome/browser/browser_signin.cc	View	1 chunk	+0 lines, -335 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.h	View	3 chunks	+0 lines, -36 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View	6 chunks	+3 lines, -130 lines	0 comments	Download
D	chrome/browser/extensions/extension_webstore_private_browsertest.cc	View	1 chunk	+0 lines, -206 lines	0 comments	Download
M	chrome/browser/profiles/profile.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
D	chrome/browser/resources/browser_signin.html	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	chrome/browser/ui/webui/options/personal_options_handler.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/options/personal_options_handler.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

LGTM. (You'll probably need someone from chrome/browser/profiles/OWNERS to review as well)

9 years, 3 months ago (2011-08-29 16:44:33 UTC) #2

Andrew T Wilson (Slow)

Will, do you want to look at the profiles stuff?

9 years, 3 months ago (2011-08-29 17:23:20 UTC) #3

willchan no longer on Chromium

On 2011/08/29 17:23:20, Andrew T Wilson wrote: > Will, do you want to look at ...

9 years, 3 months ago (2011-08-29 17:34:38 UTC) #4

Change committed as 98690

Expand Messages | Collapse Messages