Restoring a session should restore window minimization state on Windows

views/views_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_VIEWS_DELEGATE_H_
 #define VIEWS_VIEWS_DELEGATE_H_
 #pragma once
 
 #include <string>
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include "ui/base/accessibility/accessibility_types.h"
+#include "ui/base/ui_base_types.h"
 #include "views/views_export.h"
 
 namespace gfx {
 class Rect;
 }
 
 namespace ui {
 class Clipboard;
 }
 
@@ skipping 14 matching lines @@
 
   // Gets the clipboard.
   virtual ui::Clipboard* GetClipboard() const = 0;
 
   // Returns the View that all synthetic widgets created without a specified
   // parent will be parented to if they do not specify a parent in their
   // InitParams, or NULL if they should have no parent.
   // TODO(beng): perhaps this should be a Widget.
   virtual View* GetDefaultParentView() = 0;
 
-  // Saves the position, size and maximized state for the window with the
+  // Saves the position, size and "show" state for the window with the
   // specified name.
   virtual void SaveWindowPlacement(const Widget* widget,
                                    const std::wstring& window_name,
                                    const gfx::Rect& bounds,
-                                   bool maximized) = 0;
+                                   ui::WindowShowState show_state) = 0;
 
   // Retrieves the saved position and size for the window with the specified
   // name.
   virtual bool GetSavedWindowBounds(const std::wstring& window_name,
                                     gfx::Rect* bounds) const = 0;
 
-  // Retrieves the saved maximized state for the window with the specified
+  // Retrieves the saved "show" state for the window with the specified
   // name.
-  virtual bool GetSavedMaximizedState(const std::wstring& window_name,
-                                      bool* maximized) const = 0;
+  virtual bool GetSavedWindowShowState(

[sky, 2011/08/26 16:26:20]

Since you're here, is it possible to combine GetSavedWindowBounds and
GetSavedWindowShowState into one method that takes the gfx::Rect* and
windowshowstate* ? I don't know why we ended up with two.

[dhollowa, 2011/08/26 22:13:50]

Done.

I've gone with |GetSavedWindowPlacement| throughout.  This applies to the
ViewsDelegate hierarchy as well as the WidgetDelegate hierarchy.

I've also propagated the "Placement" terminology into
|NativeWidget::GetWindowPlacement| (it was
|NativeWidget::GetWindowBoundsAndShowState|).

There are further opportunities in |WindowSizer| and |Browser| but I stopped
short because the use-patterns with those are a touch complex.  A follow-up
patch possibly.

+      const std::wstring& window_name,
+      ui::WindowShowState* show_state) const = 0;
 
   virtual void NotifyAccessibilityEvent(
       views::View* view, ui::AccessibilityTypes::Event event_type) = 0;
 
   // For accessibility, notify the delegate that a menu item was focused
   // so that alternate feedback (speech / magnified text) can be provided.
   virtual void NotifyMenuItemFocused(
       const std::wstring& menu_name,
       const std::wstring& menu_item_name,
       int item_index,
@@ skipping 13 matching lines @@
   // Converts views::Event::flags to a WindowOpenDisposition.
   virtual int GetDispositionForEvent(int event_flags) = 0;
 
   // The active ViewsDelegate used by the views system.
   static ViewsDelegate* views_delegate;
 };
 
 }  // namespace views
 
 #endif  // VIEWS_VIEWS_DELEGATE_H_