Close last tab test

chrome/test/functional/chromeos_browser.py

+#!/usr/bin/python
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import pyauto_functional # pyauto_functional must come before pyauto

[dennis_jeffrey, 2011/08/26 01:35:50]

nit: add period at end of comment sentence

[tturchetto, 2011/08/26 02:07:37]

Done.

+import pyauto
+
+
+class ChromeosBrowserTest(pyauto.PyUITest):
+
+  def testCloseAllTabs(self):
+    """Close all tabs and verifies 1 tab is still open on Chrome OS."""

[dennis_jeffrey, 2011/08/26 01:35:50]

nit: choose 1 of the following:

1) 'verifies' --> 'verify'
2) 'Close' --> 'Closes'

[tturchetto, 2011/08/26 02:07:37]

Done.

+    tab_count = self.GetTabCount()
+
+    for tab_index in xrange(tab_count - 1, -1, -1):

[dennis_jeffrey, 2011/08/26 01:35:50]

(optional): I think it should work the same if you change this line to:

for tab_index in xrange(tab_count, 0, -1):

It must have been an unrelated error you saw last time, since I don't think this
change should cause an error; if it does, I'd like to know why :-)

[tturchetto, 2011/08/26 02:07:37]

Chatted this offline. Will keep as it is.

On 2011/08/26 01:35:50, dennis_jeffrey wrote:

[dennis_jeffrey, 2011/08/26 02:12:45]

Yes, I had made a mistake: if we make the change I suggested, that actually
changes the values that get set in the "tab_index" variable, which is used in
the next line below.  Changing those values led to an invalid tab index being
specified in the call to GetTab below, causing a crash.  Sorry about that!

+      self.GetBrowserWindow(0).GetTab(tab_index).Close(True)
+
+    info = self.GetBrowserInfo()
+    self.assertEqual(1, len(info['windows']))
+    self.assertEqual(1, len(info['windows'][0]['tabs']))
+    self.assertEqual('chrome://newtab/', info['windows'][0]['tabs'][0]['url'])

[dennis_jeffrey, 2011/08/26 01:35:50]

Remove this line; this is already checked now in lines 23-25 below.

[tturchetto, 2011/08/26 02:07:37]

Done.

+    url = info['windows'][0]['tabs'][0]['url']
+    self.assertEqual('chrome://newtab/', url,
+                     msg = 'Unexpected URL: %s' % url)

[dennis_jeffrey, 2011/08/26 01:35:50]

remove the spaces before and after the '='

[tturchetto, 2011/08/26 02:07:37]

Done.

+
+
+if __name__ == '__main__':
+  pyauto_functional.Main()