Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 7748026: content: Reapply "Start splitting up chrome/browser/ui/gtk/gtk_util.h" (r98287) (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 3 months ago
Reviewers:
evanm
CC:
chromium-reviews, tfarina, Erik does not do reviews, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

content: Reapply "Start splitting up chrome/browser/ui/gtk/gtk_util.h" (r98287) Now with fixes for builds that trybots don't cover by default. (This yak needs shaving because chunks of gtk using code in chrome/ are being moved to content/ to build the content_shell, but we can't depend on code in chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig constants, widget factory functions, etc instead of just moving the file.) BUG=93804 TEST=none; code move First Review URL: http://codereview.chromium.org/7737001 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98711

Patch Set 1 #

Patch Set 2 : Rebase and try one more time w/ touch #

Patch Set 3 : Rebase on Monday. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -179 lines) Patch
M chrome/browser/speech/speech_input_bubble_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/edit_search_engine_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/external_protocol_dialog_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_bubble.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_cookie_view.cc View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/importer/import_lock_dialog_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/importer/import_progress_dialog_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/page_info_bubble_gtk.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/repost_form_warning_gtk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/theme_install_bubble_view_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A ui/base/gtk/gtk_hig_constants.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ui/base/gtk/gtk_hig_constants.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Same patch plus one changed chromeos/views file (just an #include)
9 years, 3 months ago (2011-08-29 20:48:30 UTC) #1
evanm
9 years, 3 months ago (2011-08-29 20:54:48 UTC) #2
Rubber stamp.  (I suggest reusing the previous review: "git cl issue
7737001".  Then it's easy to edit the commit message to remove the
"Committed" line and replace it with "retry of blah with xx changed.)

On Mon, Aug 29, 2011 at 1:48 PM,  <erg@chromium.org> wrote:
> Reviewers: evanm,
>
> Message:
> Same patch plus one changed chromeos/views file (just an #include)
>
> Description:
> content: Reapply "Start splitting up chrome/browser/ui/gtk/gtk_util.h"
> (r98287)
>
> Now with fixes for builds that trybots don't cover by default.
>
> BUG=93804
> TEST=none; code move
> First Review URL: http://codereview.chromium.org/7737001
>
>
> Please review this at http://codereview.chromium.org/7748026/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/speech/speech_input_bubble_gtk.cc
>  M chrome/browser/ui/gtk/about_chrome_dialog.cc
>  M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
>  M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc
>  M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc
>  M chrome/browser/ui/gtk/browser_titlebar.cc
>  M chrome/browser/ui/gtk/browser_window_gtk.cc
>  M chrome/browser/ui/gtk/bubble/bubble_gtk.cc
>  M chrome/browser/ui/gtk/certificate_viewer.cc
>  M chrome/browser/ui/gtk/collected_cookies_gtk.cc
>  M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc
>  M chrome/browser/ui/gtk/constrained_window_gtk.cc
>  M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc
>  M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc
>  M chrome/browser/ui/gtk/crypto_module_password_dialog.cc
>  M chrome/browser/ui/gtk/edit_search_engine_dialog.cc
>  M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
>  M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc
>  M chrome/browser/ui/gtk/external_protocol_dialog_gtk.cc
>  M chrome/browser/ui/gtk/find_bar_gtk.cc
>  M chrome/browser/ui/gtk/first_run_bubble.cc
>  M chrome/browser/ui/gtk/first_run_dialog.cc
>  M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc
>  M chrome/browser/ui/gtk/gtk_chrome_cookie_view.cc
>  M chrome/browser/ui/gtk/gtk_theme_service.cc
>  M chrome/browser/ui/gtk/gtk_util.h
>  M chrome/browser/ui/gtk/gtk_util.cc
>  M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc
>  M chrome/browser/ui/gtk/importer/import_lock_dialog_gtk.cc
>  M chrome/browser/ui/gtk/importer/import_progress_dialog_gtk.cc
>  M chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc
>  M chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.cc
>  M chrome/browser/ui/gtk/infobars/infobar_gtk.cc
>  M chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc
>  M chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc
>  M chrome/browser/ui/gtk/location_bar_view_gtk.cc
>  M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
>  M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc
>  M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc
>  M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
>  M chrome/browser/ui/gtk/page_info_bubble_gtk.cc
>  M chrome/browser/ui/gtk/repost_form_warning_gtk.cc
>  M chrome/browser/ui/gtk/sad_tab_gtk.cc
>  M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc
>  M chrome/browser/ui/gtk/status_bubble_gtk.cc
>  M chrome/browser/ui/gtk/task_manager_gtk.cc
>  M chrome/browser/ui/gtk/theme_install_bubble_view_gtk.cc
>  M chrome/browser/ui/login/login_prompt_gtk.cc
>  M chrome/browser/ui/views/constrained_html_delegate_gtk.cc
>  A ui/base/gtk/gtk_hig_constants.h
>  A ui/base/gtk/gtk_hig_constants.cc
>  M ui/ui.gyp
>
>
>

Powered by Google App Engine
This is Rietveld 408576698