Add a bunch of compile-time flags to the gyp build (and top-level Makefile)

Add a bunch of compile-time flags to the gyp build (and top-level Makefile)

Committed: http://code.google.com/p/v8/source/detail?r=9025

[Jakob Kummerow, 2011-08-25 15:35:41]

PTAL.

[Yang, 2011-08-26 07:26:42]

The env file doesn't seem to work. I compiled the first time with
console=readline. The second time without, but nothing is recompiled. The third
attempt with library=shared, but nothing recompiled either.

+ comments below.

http://codereview.chromium.org/7748018/diff/1/Makefile
File Makefile (right):

http://codereview.chromium.org/7748018/diff/1/Makefile#newcode101
Makefile:101: $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
trailing whitespace.

http://codereview.chromium.org/7748018/diff/1/Makefile#newcode112
Makefile:112: else mv $(ENVFILE).new $(ENVFILE); fi
/bin/sh: out/environment.new: No such file or directory
mv: cannot stat `out/environment.new': No such file or directory
make: *** [generate_environment_file] Error 1

Take care of the case where OUTDIR doesnt exist. A simple mkdir -p before
checking env file would suffice.

http://codereview.chromium.org/7748018/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7748018/diff/1/build/common.gypi#newcode63
build/common.gypi:63: 'v8_enable_gdbjit%': 0,
Maybe add some comments like those options above. Or not if you think its
unnecessary.

[Jakob Kummerow, 2011-08-26 09:45:33]

Thanks for the thorough testing!

Please take another look. I think everything works now :-)

http://codereview.chromium.org/7748018/diff/1/Makefile
File Makefile (right):

http://codereview.chromium.org/7748018/diff/1/Makefile#newcode101
Makefile:101: $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
On 2011/08/26 07:26:42, Yang wrote:
> trailing whitespace.

Done.

http://codereview.chromium.org/7748018/diff/1/Makefile#newcode112
Makefile:112: else mv $(ENVFILE).new $(ENVFILE); fi
On 2011/08/26 07:26:42, Yang wrote:
> /bin/sh: out/environment.new: No such file or directory
> mv: cannot stat `out/environment.new': No such file or directory
> make: *** [generate_environment_file] Error 1
> 
> Take care of the case where OUTDIR doesnt exist. A simple mkdir -p before
> checking env file would suffice.

Done.

http://codereview.chromium.org/7748018/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7748018/diff/1/build/common.gypi#newcode63
build/common.gypi:63: 'v8_enable_gdbjit%': 0,
On 2011/08/26 07:26:42, Yang wrote:
> Maybe add some comments like those options above. Or not if you think its
> unnecessary.

This option's description in the SConstruct file is  "Enable GDB JIT interface"
-- I don't think that gives much additional information ;-)
Similar for the other two uncommented options. Their names are just as verbose
as a comment would be.

[Yang, 2011-08-26 11:00:58]

LGTM.