Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 7748012: Fix incorrect API version information. (Closed)

Created:
9 years, 4 months ago by noelallen1
Modified:
9 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix incorrect API version information. Several IDL files contain references to M13 which are unused. This causes the generator to use M13 instead of M14 as the version number for the unchanged interface. This CL removes the unused references to M13 in the IDL, and pushes the updated set of '*.h' removing the unused #define of the unused version string. BUG= http://code.google.com/p/chromium/issues/detail?id=94201 TEST= compile + try R= brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98348

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -50 lines) Patch
M ppapi/api/pp_stdint.idl View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/api/ppb_audio.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_audio_config.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_file_io.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_file_ref.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_file_system.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_graphics_2d.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_image_data.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_messaging.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_url_loader.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_url_request_info.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_url_response_info.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_var.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppp_messaging.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/c/ppb_audio.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_audio_config.h View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/c/ppb_file_io.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_file_ref.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_file_system.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_image_data.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_instance.h View 1 chunk +7 lines, -0 lines 1 comment Download
M ppapi/c/ppb_messaging.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_url_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_url_request_info.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_url_response_info.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppb_var.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/c/ppp_messaging.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
LGTM
9 years, 4 months ago (2011-08-25 23:18:19 UTC) #1
dmichael (off chromium)
9 years, 3 months ago (2011-08-30 16:02:37 UTC) #2
http://codereview.chromium.org/7748012/diff/1/ppapi/c/ppb_instance.h
File ppapi/c/ppb_instance.h (right):

http://codereview.chromium.org/7748012/diff/1/ppapi/c/ppb_instance.h#newcode85
ppapi/c/ppb_instance.h:85: PP_Bool (*BindGraphics)(PP_Instance instance,
PP_Resource device);
Please update the IDL to remove the 0.5 version and take this struct back out.
It's not supported anywhere anymore.

Powered by Google App Engine
This is Rietveld 408576698