Issue 7748011: Fix the build dependencies for safe_browsing_proto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7748011: Fix the build dependencies for safe_browsing_proto. (Closed)

Created:
9 years, 4 months ago by Brian Ryner

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, noelutz, mattm

CC:
chromium-reviews, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix the build dependencies for safe_browsing_proto. browser needs to depend on safe_browsing_proto directly since hard_dependency is not transitive. Given this requirement, there's no reason for common to depend on safe_browsing_proto. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98346

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome_common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattm

On 2011/08/25 05:09:18, noelutz wrote: > On 2011/08/25 04:43:04, Brian Ryner wrote: > > LGTM ...

9 years, 4 months ago (2011-08-25 19:48:45 UTC) #3

Change committed as 98346

Expand Messages | Collapse Messages