Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: chrome/browser/chromeos/notifications/notification_panel.cc

Issue 7747044: [chromeos] Do not move notifications to KEEP_SIZE state when mouse moved. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/notifications/notification_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/notifications/notification_panel.cc
===================================================================
--- chrome/browser/chromeos/notifications/notification_panel.cc (revision 97846)
+++ chrome/browser/chromeos/notifications/notification_panel.cc (working copy)
@@ -651,11 +651,15 @@
void NotificationPanel::OnMouseMotion(const gfx::Point& point) {
SetActiveView(balloon_container_->FindBalloonView(point));
- SET_STATE(KEEP_SIZE);
// We need to set the focus to scroll view to get mouse wheel
// working. Setting focus when mouse moves on the panel
// because focus may be taken by other view.
scroll_view_->RequestFocus();
+ // This method used to set KEEP_SIZE state. However,
+ // some html notifications may want to change their size,
+ // and setting KEEP_SIZE caused them to behave differently
+ // depending on whether user moved mouse over notification
+ // or not.
}
NotificationPanelTester* NotificationPanel::GetTester() {
« no previous file with comments | « chrome/browser/chromeos/notifications/notification_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698