Issue 7747044: [chromeos] Do not move notifications to KEEP_SIZE state when mouse moved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747044: [chromeos] Do not move notifications to KEEP_SIZE state when mouse moved. (Closed)

Created:
9 years, 4 months ago by dgozman

Modified:
9 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[chromeos] Do not move notifications to KEEP_SIZE state when mouse moved. This allows notification to resize. BUG=chromium-os:16050 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98618

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/notifications/notification_browsertest.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
	M	chrome/browser/chromeos/notifications/notification_panel.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM with following addressed. http://codereview.chromium.org/7747044/diff/1/chrome/browser/chromeos/notifications/notification_panel.cc File chrome/browser/chromeos/notifications/notification_panel.cc (right): http://codereview.chromium.org/7747044/diff/1/chrome/browser/chromeos/notifications/notification_panel.cc#newcode653 chrome/browser/chromeos/notifications/notification_panel.cc:653: SetActiveView(balloon_container_->FindBalloonView(point)); Can you add comment ...

9 years, 4 months ago (2011-08-26 18:17:46 UTC) #2

dgozman

9 years, 3 months ago (2011-08-29 07:03:17 UTC) #3

Thanks, committing.

http://codereview.chromium.org/7747044/diff/1/chrome/browser/chromeos/notific...
File chrome/browser/chromeos/notifications/notification_panel.cc (right):

http://codereview.chromium.org/7747044/diff/1/chrome/browser/chromeos/notific...
chrome/browser/chromeos/notifications/notification_panel.cc:653:
SetActiveView(balloon_container_->FindBalloonView(point));
On 2011/08/26 18:17:46, oshima wrote:
> Can you add comment that this used to set the state to KEEP_SIZE and explain
why
> we chagned it?

Done.

Expand Messages | Collapse Messages

Issue 7747044: [chromeos] Do not move notifications to KEEP_SIZE state when mouse moved. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages