Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 7747043: WORK IN PROGRESS. (Closed)

Created:
9 years, 4 months ago by not at google - send to devlin
Modified:
9 years, 3 months ago
Reviewers:
Ben Olmstead, akalin
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

WORK IN PROGRESS. Enables sync for extension settings. BUG=To be filed TEST=Unit tests

Patch Set 1 #

Patch Set 2 : Small change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1663 lines, -26 lines) Patch
M chrome/browser/extensions/extension_settings.h View 5 chunks +52 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_settings.cc View 7 chunks +162 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_settings_api.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_settings_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_settings_storage.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_settings_storage_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/extensions/extension_settings_sync_data.h View 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_settings_sync_data.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_settings_sync_helper.h View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_settings_sync_helper.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_settings_sync_unittest.cc View 1 1 chunk +473 lines, -0 lines 0 comments Download
A chrome/browser/extensions/syncable_extension_settings_storage.h View 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/browser/extensions/syncable_extension_settings_storage.cc View 1 chunk +389 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 5 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/browser/sync/protocol/extension_setting_specifics.proto View 1 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 12 chunks +28 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M chrome/chrome_browser.gypi View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/testserver/chromiumsync.py View 1 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
not at google - send to devlin
As I said, this is a work in progress, though quite close to being finished. ...
9 years, 4 months ago (2011-08-26 09:58:46 UTC) #1
Matt Perry
I'm going to be out next week, and I think Ben is working on extension ...
9 years, 4 months ago (2011-08-26 18:36:03 UTC) #2
not at google - send to devlin
9 years, 3 months ago (2011-08-29 09:06:18 UTC) #3
Don't look at this any more; look at http://codereview.chromium.org/7775008/
instead, the non-WIP (and synced to tip) version.

Powered by Google App Engine
This is Rietveld 408576698