Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 7747040: Now gracefully deals with TypedURLs with no typed visits. (Closed)

Created:
9 years, 4 months ago by Andrew T Wilson (Slow)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Now gracefully deals with TypedURLs with no typed visits. BUG=94308 TEST=Run unit tests - I don't have any way to reproduce the corrupted DB this CL works around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/sync/glue/typed_url_model_associator.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrew T Wilson (Slow)
Please take a look.
9 years, 3 months ago (2011-08-27 05:55:41 UTC) #1
Rick Campbell
LGTM
9 years, 3 months ago (2011-08-29 17:11:29 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-08-29 19:30:17 UTC) #3
Change committed as 98673

Powered by Google App Engine
This is Rietveld 408576698