Issue 7747030: Flush during SwapBuffers only on Mac OS X in order to force results to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747030: Flush during SwapBuffers only on Mac OS X in order to force results to (Closed)

Created:
9 years, 4 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 3 months ago

Reviewers:
Nico, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, jamesr, nduca

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Flush during SwapBuffers only on Mac OS X in order to force results to be displayed on screen. BUG=94325 TEST=none (tested manually with WebGL aquarium) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98329

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

It looks like this improved perceived new tab latency by 30ms / 21%: http://build.chromium.org/f/chromium/perf/mac-release-10.6/new-tab-ui-warm/report.html?history=500&header=&rev=-1

9 years, 3 months ago (2011-09-01 20:09:03 UTC) #3

jamesr

The New Tab Page doesn't use the compositing path at all, so I'd be susprised ...

9 years, 3 months ago (2011-09-01 20:12:54 UTC) #4

Nico

9 years, 3 months ago (2011-09-01 20:15:12 UTC) #5

Hm, I guess it could also be one of

http://src.chromium.org/viewvc/chrome?view=rev&revision=98322
http://src.chromium.org/viewvc/chrome?view=rev&revision=98333

Expand Messages | Collapse Messages