Ignore C++ comments while checking for Singleton<T> in headers.

Ignore C++ comments while checking for Singleton<T> in headers.

(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98421

[M-A Ruel, 2011-08-25 18:34:31]

lgtm

[commit-bot: I haz the power, 2011-08-25 18:42:45]

Presubmit check for 7747023-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/gclient_smoketest.py failed!
Command tests/gclient_smoketest.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.......F................................
======================================================================
FAIL: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1046, in testMultiSolutionsJobs
    untangle=True)
  File "tests/gclient_smoketest.py", line 77, in parseGclient
    return self.checkBlock(stdout, items)
  File "tests/gclient_smoketest.py", line 137, in checkBlock
    self.checkString(results[i][0][2], path, (i, results[i][0][2], path))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/fake_repos.py",
line 682, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: (3,
'/tmp/trialL2LC8U/__main__.GClientSmokeBoth.testMultiSolutionsJobs',
'/tmp/trialL2LC8U/__main__.GClientSmokeBoth.testMultiSolutionsJobs/src/file/other')

----------------------------------------------------------------------
Ran 40 tests in 220.952s

FAILED (failures=1)


tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
...........EE...................
======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 758, in testUpdateUnstagedConflict
    scm.update(options, (), [])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/gclient_scm.py", line
398, in update
    raise gclient_utils.Error(e.stderr)
Error: error: Your local changes to 'b' would be overwritten by merge. 
Aborting.
Please, commit your changes or stash them before you can merge.


======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 540, in tearDown
    StdoutCheck.tearDown(self)
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/super_mox.py",
line 100, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != '\n_____ . at refs/heads/master\n'

----------------------------------------------------------------------
Ran 31 tests in 1.424s

FAILED (errors=2)


Install google_appengine sdk in
/mnt/data/b/commit-queue/workdir/tools/google_appengine

Presubmit checks took 344.6s to calculate.

[Denis Lagno, 2011-08-26 13:05:23]

PTAL

[M-A Ruel, 2011-08-26 13:12:45]

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
File depot_tools/presubmit_canned_checks.py (right):

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
depot_tools/presubmit_canned_checks.py:1: # Copyright (c) 2010 The Chromium
Authors. All rights reserved.
sorry but can you update it to 2011? Since the CQ is broken for depot_tools, it
won't be auto updated.

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
depot_tools/presubmit_canned_checks.py:835: return pattern.sub('', line)
I'm not sure it's useful; using "input_api.re.sub(r'//.*$', '', line)" directly
at the call point, or on a separate named variable around like 843 since the
line would become longer, would be clearer IMHO.

wdyt?

[Denis Lagno, 2011-08-26 13:31:33]

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
File depot_tools/presubmit_canned_checks.py (right):

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
depot_tools/presubmit_canned_checks.py:1: # Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/08/26 13:12:45, Marc-Antoine Ruel wrote:
> sorry but can you update it to 2011? Since the CQ is broken for depot_tools,
it
> won't be auto updated.

Done.

http://codereview.chromium.org/7747023/diff/3001/depot_tools/presubmit_canned...
depot_tools/presubmit_canned_checks.py:835: return pattern.sub('', line)
On 2011/08/26 13:12:45, Marc-Antoine Ruel wrote:
> I'm not sure it's useful; using "input_api.re.sub(r'//.*$', '', line)"
directly
> at the call point, or on a separate named variable around like 843 since the
> line would become longer, would be clearer IMHO.
> 
> wdyt?

Done.

[M-A Ruel, 2011-08-26 13:40:39]

lgtm

Note: it would have been nice if there was a test but the initial author didn't
write one so I don't care.