Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 7747016: Allow the NetworkDelegate to synchronously cancel a URLRequest. (Closed)

Created:
9 years, 4 months ago by Joao da Silva
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Allow the NetworkDelegate to synchronously cancel a URLRequest. BUG=49612 TEST=net_unittests:URLRequestTestHTTP.NetworkDelegateCancelRequestSynchronously Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98978

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M net/url_request/url_request.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
This is part of a larger CL (http://codereview.chromium.org/7716003), that can determine to cancel a URLRequest ...
9 years, 4 months ago (2011-08-25 13:52:10 UTC) #1
Matt Perry
lgtm
9 years, 4 months ago (2011-08-25 18:12:55 UTC) #2
Joao da Silva
@eroman: ping (need owner approval)
9 years, 3 months ago (2011-08-29 08:23:56 UTC) #3
eroman
LGTM
9 years, 3 months ago (2011-08-30 18:49:00 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 16:12:40 UTC) #5
Change committed as 98978

Powered by Google App Engine
This is Rietveld 408576698