Issue 7747015: Prevent initialization of the Input Method Manager after the APP_TERMINATING message has been sent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747015: Prevent initialization of the Input Method Manager after the APP_TERMINATING message has been sent. (Closed)

Created:
9 years, 4 months ago by Zachary Kuznia

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Daniel Erat

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent initialization of the Input Method Manager after the APP_TERMINATING message has been sent. R=derat@chromium.org BUG=chromium-os:12402 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98404

Patch Set 2 : Code Review Fixes #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_manager.cc	View	1	4 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

Thanks! LGTM. http://codereview.chromium.org/7747015/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc File chrome/browser/chromeos/input_method/input_method_manager.cc (right): http://codereview.chromium.org/7747015/diff/1/chrome/browser/chromeos/input_method/input_method_manager.cc#newcode837 chrome/browser/chromeos/input_method/input_method_manager.cc:837: LOG(ERROR) << "Trying to launch input method ...

9 years, 4 months ago (2011-08-25 14:08:19 UTC) #2

Change committed as 98404

Expand Messages | Collapse Messages

Issue 7747015: Prevent initialization of the Input Method Manager after the APP_TERMINATING message has been sent. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code Review Fixes #

Messages