Issue 7747011: Revert 98112

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747011: Revert 98112 (Closed)

Created:
9 years, 4 months ago by Nico

Modified:
9 years, 4 months ago

Reviewers:
jennb

CC:
chromium-reviews, jianli, Dmitry Titov, dcheng, prasadt, jbates

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 98112 BrowserKeyEventsTest.ReservedAccelerators started failing, and this looks like the most likely candidate in the window: http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/14075 http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%281%29/builds/12226 - Handle keyboard shortcuts in Mac Panels. Common code from browser_window_cocoa separated into cocoa/browser_window_utils. Panel.xib changed to make the NSWindow for the PanelWindowControllerCocoa a ChromeEventProcessingWindow. BUG=None TEST=Manual testing with Panels and keyboard shortcuts to find/next/previous/close window/quit chrome. Review URL: http://codereview.chromium.org/7719016 TBR=jennb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98186

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -190 lines)			Patch
M	chrome/app/nibs/Panel.xib	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	3 chunks	+113 lines, -10 lines	0 comments	Download
D	chrome/browser/ui/cocoa/browser_window_utils.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/browser/ui/cocoa/browser_window_utils.mm	View	1 chunk	+0 lines, -121 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa.mm	View	2 chunks	+2 lines, -19 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennb

9 years, 4 months ago (2011-08-25 22:00:48 UTC) #4

On 2011/08/25 06:33:50, Nico wrote:
> (The test went green after this revert.)

I can't get this to repro locally and it passed on the trybot. Do you see
anything strange in this patch that would break key event handling in regular
browser windows? All I did was move code from browser_window_cocoa into
browser_window_utils. Did I break something going from C++ to ObjC?

Expand Messages | Collapse Messages