Add metrics to track Autofill "user happiness"

chrome/browser/autofill/form_structure.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 617 matching lines @@
   DCHECK_EQ(cached_form.source_url_, source_url_);
   DCHECK_EQ(cached_form.target_url_, target_url_);
   form_signature_field_names_ = cached_form.form_signature_field_names_;
 }
 
 void FormStructure::LogQualityMetrics(
     const AutofillMetrics& metric_logger) const {
   std::string experiment_id = server_experiment_id();
   metric_logger.LogServerExperimentIdForUpload(experiment_id);
 
+  size_t num_detected_field_types = 0;
   for (size_t i = 0; i < field_count(); ++i) {
     const AutofillField* field = this->field(i);
     metric_logger.LogQualityMetric(AutofillMetrics::FIELD_SUBMITTED,
                                    experiment_id);
 
     // No further logging for empty fields nor for fields where the entered data
     // does not appear to already exist in the user's stored Autofill data.
     const FieldTypeSet& field_types = field->possible_types();
     DCHECK(!field_types.empty());
     if (field_types.count(EMPTY_TYPE) || field_types.count(UNKNOWN_TYPE))
       continue;
 
+    ++num_detected_field_types;
+
     // Collapse field types that Chrome treats as identical, e.g. home and
     // billing address fields.
     FieldTypeSet collapsed_field_types;
     for (FieldTypeSet::const_iterator it = field_types.begin();
          it != field_types.end();
          ++it) {
       // Since we currently only support US phone numbers, the (city code + main
       // digits) number is almost always identical to the whole phone number.
       // TODO(isherman): Improve this logic once we add support for
       // international numbers.
@@ skipping 83 matching lines @@
         metric_logger.LogQualityMetric(
             AutofillMetrics::NOT_AUTOFILLED_SERVER_TYPE_MATCH,
             experiment_id);
       } else {
         metric_logger.LogQualityMetric(
             AutofillMetrics::NOT_AUTOFILLED_SERVER_TYPE_MISMATCH,
             experiment_id);
       }
     }
   }
-}
 
-void FormStructure::set_possible_types(size_t index,
-                                       const FieldTypeSet& types) {
-  if (index >= fields_.size()) {
-    NOTREACHED();
-    return;
+  if (num_detected_field_types >= kRequiredFillableFields) {
+    metric_logger.LogUserHappinessMetric(
+        AutofillMetrics::SUBMITTED_FORM_COULD_HAVE_BEEN_AUTOFILLED);
   }
-
-  fields_[index]->set_possible_types(types);
 }
 
 const AutofillField* FormStructure::field(size_t index) const {
   if (index >= fields_.size()) {
     NOTREACHED();
     return NULL;
   }
 
   return fields_[index];
 }
 
+AutofillField* FormStructure::field(size_t index) {
+  return const_cast<AutofillField*>(
+      static_cast<const FormStructure*>(this)->field(index));
+}
+
 size_t FormStructure::field_count() const {
   return fields_.size();
 }
 
 std::string FormStructure::server_experiment_id() const {
   return server_experiment_id_;
 }
 
 bool FormStructure::operator==(const FormData& form) const {
   // TODO(jhawkins): Is this enough to differentiate a form?
@@ skipping 146 matching lines @@
     if (current_type != UNKNOWN_TYPE && already_saw_current_type) {
       // We reached the end of a section, so start a new section.
       seen_types.clear();
       current_section = (*field)->unique_name();
     }
 
     seen_types.insert(current_type);
     (*field)->set_section(current_section);
   }
 }