Call bootstrapencryption before sending initialization complete.

Call bootstrapencryption before sending initialization complete.

BUG=86429
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98387

[lipalani1, 2011-08-24 23:00:28]

Please review. This is a stable blocker.

[Nicolas Zea, 2011-08-25 01:22:46]

LGTM if Tim's good with it. Tim, for reference, the order of these lines was
changed in http://codereview.chromium.org/7003077, but we think it was by
accident.

http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/sync_manager.cc (right):

http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/sync_manager.cc:790: // The following calls
check that initialized_ is true.
We can get rid of this comment, it no longer applies.

[lipalani, 2011-08-25 01:32:53]

actually they do check initialized_ is true!

On Wed, Aug 24, 2011 at 6:22 PM, <zea@chromium.org> wrote:

> LGTM if Tim's good with it. Tim, for reference, the order of these lines
> was
> changed in
http://codereview.chromium.**org/7003077<http://codereview.chromium.org/7003077>,
> but we think it was by
> accident.
>
>
> http://codereview.chromium.**org/7747001/diff/2001/chrome/**
>
browser/sync/internal_api/**sync_manager.cc<http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal_api/sync_manager.cc>
> File chrome/browser/sync/internal_**api/sync_manager.cc (right):
>
> http://codereview.chromium.**org/7747001/diff/2001/chrome/**
>
browser/sync/internal_api/**sync_manager.cc#newcode790<http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal_api/sync_manager.cc#newcode790>
> chrome/browser/sync/internal_**api/sync_manager.cc:790: // The following
>
> calls check that initialized_ is true.
> We can get rid of this comment, it no longer applies.
>
>
>
http://codereview.chromium.**org/7747001/<http://codereview.chromium.org/7747...
>

[tim (not reviewing), 2011-08-25 15:42:43]

Especially if this is a stable blocker, please affix BUG=

I'm having a serious case of deja-vu on this... sad that I reviewed that patch
too, but sadder that I honestly can't remember all the arguments as to why it
has to be in this order.  We seriously need a unit test for this somehow (?)!


LGTM

http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/sync_manager.cc (right):

http://codereview.chromium.org/7747001/diff/2001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/sync_manager.cc:791: 
remove extra newline.

[commit-bot: I haz the power, 2011-08-26 01:01:24]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2011-08-26 02:46:43]

Change committed as 98387