Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 7746011: Revert 98168, it caused compile errors on mac: (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
Reviewers:
Brian Ryner
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98168, it caused compile errors on mac: /b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/browser_feature_extractor.cc:456:12:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest' request->set_suffix_prefix_hash( ~~~~~~~ ^ 1 error generated. /b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:281:20:error: no member named 'has_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest' if (full_request.has_suffix_prefix_hash()) { ~~~~~~~~~~~~ ^ /b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:282:24:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest' sanitized_request->set_suffix_prefix_hash( ~~~~~~~~~~~~~~~~~ ^ /b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:283:22:error: no member named 'suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest' full_request.suffix_prefix_hash()); ~~~~~~~~~~~~ ^ 3 errors generated. Add support for client-side phishing detection for non-UMA users. In this mode, a sanitized pingback is sent that does not include the URL or any tokens extracted from the URL or page content. Currently, this feature is behind a command-line flag. BUG=none TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest Review URL: http://codereview.chromium.org/7635010 TBR=bryner@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -430 lines) Patch
M chrome/browser/safe_browsing/browser_feature_extractor.h View 4 chunks +59 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 3 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 3 chunks +0 lines, -50 lines 0 comments Download
D chrome/browser/safe_browsing/browser_features.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/safe_browsing/browser_features.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 7 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 5 chunks +1 line, -88 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 3 chunks +0 lines, -105 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/chrome_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/renderer/safe_browsing/features.h View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 4 months ago (2011-08-25 02:30:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698