Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 7746009: [Mac] Support windowless Flash plugin rendering directly to the context for single-process apps (Closed)

Created:
9 years, 4 months ago by Marshall
Modified:
9 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Windowless Flash plugins on Mac do not currently draw in single-process applications using the Chromium WebKit API because the current design assumes a multi-process implementation and requires a buffer context. Add a new flag to indicate no buffer context will be used and change WebPluginDelegateImpl::WindowlessPaint() to paint directly to the window context when this flag is set. Also change test_shell to force Flash plugins to run in windowless mode by setting the wmode="opaque" attribute. BUG=94395 TEST=load Flash plugin in test_shell Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98571

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -12 lines) Patch
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 5 chunks +33 lines, -10 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 1 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Marshall
Mark: please review Jam: FYI
9 years, 4 months ago (2011-08-25 01:10:10 UTC) #1
Mark Mentovai
I think this is tolerable. LGTM.
9 years, 4 months ago (2011-08-25 13:21:20 UTC) #2
Mark Mentovai
Please file a bug for this and provide a real BUG= line in your checkin ...
9 years, 4 months ago (2011-08-25 13:22:31 UTC) #3
Marshall
On 2011/08/25 13:22:31, Mark Mentovai wrote: > Please file a bug for this and provide ...
9 years, 4 months ago (2011-08-25 13:38:43 UTC) #4
Marshall
Mark: Please review test_shell changes. Jam: FYI.
9 years, 4 months ago (2011-08-26 15:04:48 UTC) #5
Mark Mentovai
LGTM
9 years, 4 months ago (2011-08-26 15:45:48 UTC) #6
commit-bot: I haz the power
9 years, 3 months ago (2011-08-27 21:07:02 UTC) #7
Change committed as 98571

Powered by Google App Engine
This is Rietveld 408576698