Issue 7745057: Speculative fix for 93314. I suspect the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7745057: Speculative fix for 93314. I suspect the (Closed)

Created:
9 years, 3 months ago by sky

Modified:
9 years, 3 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Speculative fix for 93314. I suspect the OptionMenuModel::translate_infobar_delegate_ has been deleted. This may be possible if BeforeTranslateInfoBar is deleted while the menu is showing. Changing the code like I'm doing makes sure the menu is deleted if BeforeTranslateInfoBar is deleted too. BUG=93314 TEST=none R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98693

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/infobars/before_translate_infobar.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/infobars/before_translate_infobar.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Rubber-stamp LGTM. How can the infobar be deleted while the menu is running? Maybe if ...

9 years, 3 months ago (2011-08-29 17:39:33 UTC) #2

sky

9 years, 3 months ago (2011-08-29 20:38:15 UTC) #3

On Mon, Aug 29, 2011 at 10:39 AM,  <pkasting@chromium.org> wrote:
> Rubber-stamp LGTM.  How can the infobar be deleted while the menu is
> running?
> Maybe if there was a navigation pending, and while the user interacted with
> the
> infobar the navigation committed?

Exactly, or any other operation that triggered delayed deletion (such
as unload handlers). Will see if this actually fixes it.

  -Scott

Expand Messages | Collapse Messages