Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4319)

Unified Diff: buildbot/buildbot_standard.py

Issue 7745047: Enable browser tests with glibc. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/buildbot_selector.py ('k') | buildbot/patch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/buildbot_standard.py
===================================================================
--- buildbot/buildbot_standard.py (revision 6583)
+++ buildbot/buildbot_standard.py (working copy)
@@ -101,8 +101,7 @@
inside_toolchain = context['inside_toolchain']
# When off the trunk, we don't have anywhere to get Chrome binaries
# from the appropriate branch, so we can't test the right Chrome.
- do_integration_tests = (not context['use_glibc'] and
- not inside_toolchain and
+ do_integration_tests = (not inside_toolchain and
not context['off_trunk'])
do_dso_tests = (context['use_glibc'] and
not inside_toolchain and
@@ -250,9 +249,10 @@
# TODO(mcgrathr): Clean up how we organize tests and do this differently.
# See http://code.google.com/p/nativeclient/issues/detail?id=1691
- with Step('chrome_browser_tests without IRT', status, halt_on_fail=False):
- SCons(context, browser_test=True,
- args=['SILENT=1', 'irt=0', 'chrome_browser_tests'])
+ if not do_dso_tests:
+ with Step('chrome_browser_tests without IRT', status, halt_on_fail=False):
+ SCons(context, browser_test=True,
+ args=['SILENT=1', 'irt=0', 'chrome_browser_tests'])
with Step('pyauto_tests', status, halt_on_fail=False):
SCons(context, browser_test=True, args=['SILENT=1', 'pyauto_tests'])
« no previous file with comments | « buildbot/buildbot_selector.py ('k') | buildbot/patch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698