Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7745044: Minor cleanups and improvements for the D-Bus library. (Closed)

Created:
9 years, 4 months ago by satorux1
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Minor cleanups and improvements for the D-Bus library. - Add mock_export_object.{cc,h} to dbus.gyp, which were missing. - Add a comment about shutdown of Bus in bus.h. - Update mock_unittest.cc to call ShutdownAndBlock(). - Replace DCHECKs with LOG(ERROR)s followed by early exit. - Add virtual to SetUp() and TearDown() in tests. - Renamed a member variable to make it clearer. BUG=chromium:90036 TEST=dbus_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M dbus/bus.h View 2 chunks +7 lines, -1 line 0 comments Download
M dbus/bus.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M dbus/dbus.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/end_to_end_sync_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/mock_unittest.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
9 years, 4 months ago (2011-08-26 06:39:50 UTC) #1
stevenjb
LGTM
9 years, 4 months ago (2011-08-27 00:43:52 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-27 07:26:44 UTC) #3
Change committed as 98560

Powered by Google App Engine
This is Rietveld 408576698