Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 7745041: Fix failing the plugin test: plugins.PluginsTest.testDisableEnableAllPlugins (Closed)

Created:
9 years, 4 months ago by Venkat Yellapu
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix failing the plugin test: plugins.PluginsTest.testDisableEnableAllPlugins BUG=87811 Test=plugins.PluginsTest.testDisableEnableAllPlugins Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98761

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M functional/PYAUTO_TESTS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M functional/plugins.py View 1 2 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Venkat Yellapu
This fixes: 1. AssertionError self.assertFalse(self._GetPluginPID(plugin_name=plugin_name)) 2. quicktime error : There is a mismatch in QuickTime ...
9 years, 4 months ago (2011-08-26 01:01:44 UTC) #1
Nirnimesh
http://codereview.chromium.org/7745041/diff/1/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (left): http://codereview.chromium.org/7745041/diff/1/functional/PYAUTO_TESTS#oldcode153 functional/PYAUTO_TESTS:153: '-passwords.PasswordTest.testDisplayAndSavePasswordInfobar', ?? http://codereview.chromium.org/7745041/diff/1/functional/PYAUTO_TESTS#oldcode362 functional/PYAUTO_TESTS:362: '-passwords.PasswordTest.testDisplayAndSavePasswordInfobar', ?? Why is this ...
9 years, 4 months ago (2011-08-26 01:17:05 UTC) #2
Venkat Yellapu
Reflected the changes. Thanks. http://codereview.chromium.org/7745041/diff/1/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (left): http://codereview.chromium.org/7745041/diff/1/functional/PYAUTO_TESTS#oldcode153 functional/PYAUTO_TESTS:153: '-passwords.PasswordTest.testDisplayAndSavePasswordInfobar', On 2011/08/26 01:17:05, Nirnimesh ...
9 years, 4 months ago (2011-08-26 15:10:26 UTC) #3
Nirnimesh
LGTM. Please watch the bots after you commit.
9 years, 3 months ago (2011-08-27 08:56:12 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-30 02:30:36 UTC) #5
Change committed as 98761

Powered by Google App Engine
This is Rietveld 408576698