Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc

Issue 7745040: [Sync] Make P2PNotifier behave more like InvalidationNotifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix copyright Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc
diff --git a/chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc b/chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc
index 575700f63a958e9506800bf4d48849f8f6fce318..e6040a330ef67fa428e4456b40a1fb7214f79aa0 100644
--- a/chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc
+++ b/chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc
@@ -32,8 +32,7 @@ class NonBlockingInvalidationNotifier::Core
void SetUniqueId(const std::string& unique_id);
void SetState(const std::string& state);
void UpdateCredentials(const std::string& email, const std::string& token);
- void UpdateEnabledTypes(const syncable::ModelTypeSet& types);
- void SendNotification();
+ void UpdateEnabledTypes(const syncable::ModelTypeSet& enabled_types);
// SyncNotifierObserver implementation (all called on I/O thread).
virtual void OnIncomingNotification(
@@ -111,9 +110,9 @@ void NonBlockingInvalidationNotifier::Core::UpdateCredentials(
}
void NonBlockingInvalidationNotifier::Core::UpdateEnabledTypes(
- const syncable::ModelTypeSet& types) {
+ const syncable::ModelTypeSet& enabled_types) {
DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- invalidation_notifier_->UpdateEnabledTypes(types);
+ invalidation_notifier_->UpdateEnabledTypes(enabled_types);
}
void NonBlockingInvalidationNotifier::Core::OnIncomingNotification(
@@ -216,19 +215,20 @@ void NonBlockingInvalidationNotifier::UpdateCredentials(
}
void NonBlockingInvalidationNotifier::UpdateEnabledTypes(
- const syncable::ModelTypeSet& types) {
+ const syncable::ModelTypeSet& enabled_types) {
DCHECK(parent_message_loop_proxy_->BelongsToCurrentThread());
if (!io_message_loop_proxy_->PostTask(
FROM_HERE,
NewRunnableMethod(
core_.get(),
&NonBlockingInvalidationNotifier::Core::UpdateEnabledTypes,
- types))) {
+ enabled_types))) {
NOTREACHED();
}
}
-void NonBlockingInvalidationNotifier::SendNotification() {
+void NonBlockingInvalidationNotifier::SendNotification(
+ const syncable::ModelTypeSet& changed_types) {
DCHECK(parent_message_loop_proxy_->BelongsToCurrentThread());
// InvalidationClient doesn't implement SendNotification(), so no
// need to forward on the call.
« no previous file with comments | « chrome/browser/sync/notifier/non_blocking_invalidation_notifier.h ('k') | chrome/browser/sync/notifier/p2p_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698