[Sync] Make P2PNotifier behave more like InvalidationNotifier

chrome/test/live_sync/migration_errors_test.cc

Index: chrome/test/live_sync/migration_errors_test.cc
diff --git a/chrome/test/live_sync/migration_errors_test.cc b/chrome/test/live_sync/migration_errors_test.cc
index fb124a430a0de22c5fc844a162d96043bdfa83fc..0ea11878364852e260c6c5d37d8da23ea49f523a 100644
--- a/chrome/test/live_sync/migration_errors_test.cc
+++ b/chrome/test/live_sync/migration_errors_test.cc
@@ -133,7 +133,9 @@ class MigrationErrorsTest : public LiveSyncTest {
 
 // Easiest possible test of migration errors: triggers a server migration on
 // one datatype, then modifies some other datatype.
-IN_PROC_BROWSER_TEST_F(MigrationErrorsTest, MigratePrefsThenModifyBookmark) {
+// TODO(akalin): Fails due to http://crbug.com/92928.
+IN_PROC_BROWSER_TEST_F(MigrationErrorsTest,
+                       FAILS_MigratePrefsThenModifyBookmark) {

[Nicolas Zea, 2011/08/26 21:19:14]

I'd kind of prefer this (and the other failing tests in here) be disabled, as
they're actually timing out and each take ~1min to complete when they do.

[akalin, 2011/08/26 22:42:27]

Done.

   if (!ServerSupportsErrorTriggering()) {
     LOG(WARNING) << "Test skipped in this server environment.";
     return;
@@ -165,8 +167,9 @@ IN_PROC_BROWSER_TEST_F(MigrationErrorsTest, MigratePrefsThenModifyBookmark) {
 
 // Triggers a server migration on two datatypes, then makes a local
 // modification to one of them.
+// TODO(akalin): Fails due to http://crbug.com/92928.
 IN_PROC_BROWSER_TEST_F(MigrationErrorsTest,
-    MigratePrefsAndBookmarksThenModifyBookmark) {
+                       FAILS_MigratePrefsAndBookmarksThenModifyBookmark) {
   if (!ServerSupportsErrorTriggering()) {
     LOG(WARNING) << "Test skipped in this server environment.";
     return;
@@ -199,7 +202,9 @@ IN_PROC_BROWSER_TEST_F(MigrationErrorsTest,
 
 // Migrate every datatype in sequence; the catch being that the server
 // will only tell the client about the migrations one at a time.
-IN_PROC_BROWSER_TEST_F(MigrationErrorsTest, MigrationHellWithoutNigori) {
+// TODO(akalin): Fails due to http://crbug.com/92928.
+IN_PROC_BROWSER_TEST_F(MigrationErrorsTest,
+                       FAILS_MigrationHellWithoutNigori) {
   if (!ServerSupportsErrorTriggering()) {
     LOG(WARNING) << "Test skipped in this server environment.";
     return;
@@ -239,7 +244,9 @@ IN_PROC_BROWSER_TEST_F(MigrationErrorsTest, MigrationHellWithoutNigori) {
   ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
 }
 
-IN_PROC_BROWSER_TEST_F(MigrationErrorsTest, MigrationHellWithNigori) {
+// TODO(akalin): Fails due to http://crbug.com/92928.
+IN_PROC_BROWSER_TEST_F(MigrationErrorsTest,
+                       FAILS_MigrationHellWithNigori) {
   if (!ServerSupportsErrorTriggering()) {
     LOG(WARNING) << "Test skipped in this server environment.";
     return;