Add a big grab bag of missing web accessibility functionality...

webkit/glue/webaccessibility.h

Index: webkit/glue/webaccessibility.h
===================================================================
--- webkit/glue/webaccessibility.h	(revision 98225)
+++ webkit/glue/webaccessibility.h	(working copy)
@@ -131,6 +131,7 @@
   // for example:
   //   int mask = (1 << STATE_CHECKED) | (1 << STATE_FOCUSED);
   enum State {
+    STATE_BUSY,
     STATE_CHECKED,
     STATE_COLLAPSED,
     STATE_EXPANDED,
@@ -146,11 +147,13 @@
     STATE_PRESSED,
     STATE_PROTECTED,
     STATE_READONLY,
+    STATE_REQUIRED,
     STATE_SELECTABLE,
     STATE_SELECTED,
     STATE_TRAVERSED,
-    STATE_BUSY,
-    STATE_UNAVAILABLE
+    STATE_UNAVAILABLE,
+    STATE_VERTICAL,
+    STATE_VISITED

[tony, 2011/08/27 00:05:47]

Nit: Is it possible to have a compile assert that there are at most 32 States?

[dmazzoni, 2011/08/29 18:08:51]

Done.

   };
 
   // Additional optional attributes that can be optionally attached to
@@ -163,11 +166,17 @@
     ATTR_DOC_DOCTYPE,
 
     // Attributes that could apply to any node.
+    ATTR_ACCESS_KEY,
     ATTR_ACTION,
+    ATTR_CONTAINER_LIVE_RELEVANT,
+    ATTR_CONTAINER_LIVE_STATUS,
     ATTR_DESCRIPTION,
     ATTR_DISPLAY,
     ATTR_HELP,
     ATTR_HTML_TAG,
+    ATTR_LIVE_RELEVANT,
+    ATTR_LIVE_STATUS,
+    ATTR_ROLE,
     ATTR_SHORTCUT,
     ATTR_URL,
     NUM_STRING_ATTRIBUTES
@@ -192,9 +201,40 @@
     ATTR_TABLE_CELL_ROW_INDEX,
     ATTR_TABLE_CELL_ROW_SPAN,
 
+    // Tree control attributes.
+    ATTR_HIERARCHICAL_LEVEL,
+
     NUM_INT_ATTRIBUTES
   };
 
+  enum FloatAttribute {
+    // Document attributes.
+    ATTR_DOC_LOADING_PROGRESS,
+
+    // Range attributes.
+    ATTR_VALUE_FOR_RANGE,
+    ATTR_MIN_VALUE_FOR_RANGE,
+    ATTR_MAX_VALUE_FOR_RANGE,
+
+    NUM_FLOAT_ATTRIBUTES
+  };
+
+  enum BoolAttribute {
+    // Document attributes.
+    ATTR_DOC_LOADED,
+
+    // True if a checkbox or radio button is in the "mixed" state.
+    ATTR_BUTTON_MIXED,
+
+    // Live region attributes.
+    ATTR_CONTAINER_LIVE_ATOMIC,
+    ATTR_CONTAINER_LIVE_BUSY,
+    ATTR_LIVE_ATOMIC,
+    ATTR_LIVE_BUSY,
+
+    NUM_BOOL_ATTRIBUTES
+  };
+
   // Empty constructor, for serialization.
   WebAccessibility();
 
@@ -207,6 +247,8 @@
 
   ~WebAccessibility();
 
+  std::string DebugString(bool recursive);
+
  private:
   // Initialize an already-created struct, same as the constructor above.
   void Init(const WebKit::WebAccessibilityObject& src,
@@ -231,11 +273,14 @@
   gfx::Rect location;
   std::map<StringAttribute, string16> string_attributes;
   std::map<IntAttribute, int32> int_attributes;
+  std::map<FloatAttribute, float> float_attributes;
+  std::map<BoolAttribute, bool> bool_attributes;
   std::vector<WebAccessibility> children;
   std::vector<int32> indirect_child_ids;
   std::vector<std::pair<string16, string16> > html_attributes;
   std::vector<int32> line_breaks;
-  std::vector<int32> cell_ids;  // For a table, the cell ids in row-major order.
+  std::vector<int32> cell_ids;  // For a table, the cell ids in row-major order
+  std::vector<int32> unique_cell_ids;

[tony, 2011/08/27 00:05:47]

Can we just make this a set?

[dmazzoni, 2011/08/29 18:08:51]

No, the order matters and the uniqueness only needs to be enforced when it's
created. I added a comment to make this more clear.

 };
 
 }  // namespace webkit_glue