Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2234)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 7745032: ntp4: don't set shownPageIndex during startup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 48c5bd80fd37ec4174f35b9ea4958a220ab91825..31197cc1fb0c11eecb0a93df23c3bb1742a23023 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -612,19 +612,24 @@ cr.define('ntp4', function() {
*/
function cardChangedHandler(e) {
var page = e.cardSlider.currentCardValue;
- if (page.classList.contains('apps-page')) {
- shownPage = templateData['apps_page_id'];
- shownPageIndex = getAppsPageIndex(page);
- } else if (page.classList.contains('most-visited-page')) {
- shownPage = templateData['most_visited_page_id'];
- shownPageIndex = 0;
- } else if (page.classList.contains('bookmarks-page')) {
- shownPage = templateData['bookmarks_page_id'];
- shownPageIndex = 0;
- } else {
- console.error('unknown page selected');
+
+ // Don't change shownPage until startup is done (and page changes actually
+ // reflect user actions).
+ if (!document.documentElement.classList.contains('starting-up')) {
+ if (page.classList.contains('apps-page')) {
+ shownPage = templateData['apps_page_id'];
+ shownPageIndex = getAppsPageIndex(page);
+ } else if (page.classList.contains('most-visited-page')) {
+ shownPage = templateData['most_visited_page_id'];
+ shownPageIndex = 0;
+ } else if (page.classList.contains('bookmarks-page')) {
+ shownPage = templateData['bookmarks_page_id'];
+ shownPageIndex = 0;
+ } else {
+ console.error('unknown page selected');
+ }
+ chrome.send('pageSelected', [shownPage, shownPageIndex]);
}
- chrome.send('pageSelected', [shownPage, shownPageIndex]);
// Update the active dot
var curDot = dotList.getElementsByClassName('selected')[0];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698