Issue 7745021: Do not show "Translate to ..." item in context menu for chrome:// and FileBrowser pages.

Issue 7745021: Do not show "Translate to ..." item in context menu for chrome:// and FileBrowser pages. (Closed)

Created:
9 years, 4 months ago by Oleg Eterevsky

Modified:
9 years, 4 months ago

Reviewers:
rginda, achuithb, zel

CC:
chromium-reviews, Avi (use Gerrit), Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Do not show "Translate to ..." item in context menu for chrome:// and FileBrowser pages. BUG=chromium-os:17471 TEST="Translate to English" context menu items is shown on the usual pages, but not shown in FileBrowser or chrome://settings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98420

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
M	chrome/browser/extensions/file_manager_util.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/file_manager_util.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2	3 chunks	+26 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

achuithb

http://codereview.chromium.org/7745021/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/7745021/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc#newcode679 chrome/browser/tab_contents/render_view_context_menu.cc:679: static bool ShouldShowTranslateItem(GURL page_url) { Drive-by review with 2 ...

9 years, 4 months ago (2011-08-25 17:30:48 UTC) #3

Oleg Eterevsky

9 years, 4 months ago (2011-08-25 17:34:41 UTC) #4

rginda

http://codereview.chromium.org/7745021/diff/1005/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/7745021/diff/1005/chrome/browser/tab_contents/render_view_context_menu.cc#newcode72 chrome/browser/tab_contents/render_view_context_menu.cc:72: #ifdef OS_CHROMEOS The file manager has its own FILE_MANAGER_EXTENSION ...

9 years, 4 months ago (2011-08-25 20:10:16 UTC) #5

Oleg Eterevsky

9 years, 4 months ago (2011-08-26 11:08:39 UTC) #6

http://codereview.chromium.org/7745021/diff/1005/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/7745021/diff/1005/chrome/browser/tab_contents/...
chrome/browser/tab_contents/render_view_context_menu.cc:72: #ifdef OS_CHROMEOS
On 2011/08/25 20:10:16, rginda wrote:
> The file manager has its own FILE_MANAGER_EXTENSION #define, so that it may
one
> day be included in non-chromeos builds.

Fixed. Thanks.

Expand Messages | Collapse Messages