Issue 7745019: Fix crash with network menu in status area on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7745019: Fix crash with network menu in status area on Chrome OS (Closed)

Created:
9 years, 4 months ago by Dmitry Polukhin

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash with network menu in status area on Chrome OS BUG=57890 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98229

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/chromeos/status/network_menu.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 4 months ago (2011-08-25 14:43:42 UTC) #3

In the future feel free to TBR this sort of thing.

  -Scott

On Thu, Aug 25, 2011 at 7:38 AM,  <sky@chromium.org> wrote:
> GAH! Sorry
>
> LGTM
>
> http://codereview.chromium.org/7745019/
>

Expand Messages | Collapse Messages